Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 7629016: Forced cookie removal before sign-in page is shown. (Closed)

Created:
9 years, 4 months ago by zel
Modified:
9 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, rharrison
Visibility:
Public.

Description

Forced cookie removal before sign-in page is shown. TEST=none BUG=chromium-os:18248 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96903

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -13 lines) Patch
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 5 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 4 chunks +29 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zel
9 years, 4 months ago (2011-08-13 07:47:43 UTC) #1
xiyuan
http://codereview.chromium.org/7629016/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): http://codereview.chromium.org/7629016/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode261 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:261: StartClearingCookies(); Think we want to clear cookie regardless of ...
9 years, 4 months ago (2011-08-13 15:43:21 UTC) #2
zel
http://codereview.chromium.org/7629016/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): http://codereview.chromium.org/7629016/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode261 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:261: StartClearingCookies(); On 2011/08/13 15:43:21, xiyuan wrote: > Think we ...
9 years, 4 months ago (2011-08-15 06:24:34 UTC) #3
xiyuan
9 years, 4 months ago (2011-08-15 16:30:28 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698