Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 7629008: Modify registry and json files to add policies for testing popups. (Closed)

Created:
9 years, 4 months ago by aocampo
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Modify registry and json files to add policies for testing popups. BUG=NONE TEST=enterprise.EnterpriseTest.testDisablePopups, enterprise.EnterpriseTestReverse.testEnablePopups Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96813

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -187 lines) Patch
M enterprise/chrome.json View 2 chunks +2 lines, -2 lines 0 comments Download
M enterprise/chrome-add.reg View 1 2 3 4 1 chunk +92 lines, -183 lines 0 comments Download
M enterprise/chrome-add-reverse.reg View 2 chunks +2 lines, -1 line 0 comments Download
M enterprise/chrome-reverse.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
aocampo
9 years, 4 months ago (2011-08-12 00:56:37 UTC) #1
Nirnimesh
Could you add the test to this same CL please?
9 years, 4 months ago (2011-08-12 00:59:34 UTC) #2
aocampo
On 2011/08/12 00:59:34, Nirnimesh wrote: > Could you add the test to this same CL ...
9 years, 4 months ago (2011-08-12 01:06:16 UTC) #3
Nirnimesh
Where's the test?
9 years, 4 months ago (2011-08-12 01:27:29 UTC) #4
aocampo
On 2011/08/12 01:27:29, Nirnimesh wrote: > Where's the test? I submitted on a different CL ...
9 years, 4 months ago (2011-08-12 17:50:25 UTC) #5
Nirnimesh
Why not add in this same CL?
9 years, 4 months ago (2011-08-12 18:15:20 UTC) #6
Nirnimesh
../functional will not work. You need to use the minimal setup instructions so that you ...
9 years, 4 months ago (2011-08-12 18:44:14 UTC) #7
commit-bot: I haz the power
Can't apply patch for file chrome/test/data/enterprise/chrome-add.reg. While running patch -p0 --forward --force; patching file chrome/test/data/enterprise/chrome-add.reg ...
9 years, 4 months ago (2011-08-12 18:57:10 UTC) #8
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 21:03:27 UTC) #9
Can't apply patch for file chrome/test/data/enterprise/chrome-add.reg.
While running patch -p0 --forward --force;
patching file chrome/test/data/enterprise/chrome-add.reg
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/data/enterprise/chrome-add.reg.rej

Powered by Google App Engine
This is Rietveld 408576698