Issue 7628029: Don't ignore back navigations after max entry limit is reached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7628029: Don't ignore back navigations after max entry limit is reached. (Closed)

Created:
9 years, 4 months ago by Charlie Reis

Modified:
9 years, 4 months ago

Reviewers:
cbentzel, brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't ignore back navigations after max entry limit is reached. It's safe to proceed if the browser's page_id is newer than the renderer's, for a given offset into the history list. BUG=89798 TEST=RenderViewTest.DontIgnoreBackAfterNavEntryLimit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96701

Patch Set 1 : Initial draft #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -2 lines)			Patch
M	content/renderer/render_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view.cc	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View	1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages