Issue 7628025: Gracefully handle multiple Flush/Reset/Decode with same id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7628025: Gracefully handle multiple Flush/Reset/Decode with same id (Closed)

Created:
9 years, 4 months ago by piman

Modified:
9 years, 4 months ago

Reviewers:
vrk (LEFT CHROMIUM), commit-bot: I haz the power, Ami GONE FROM CHROMIUM

CC:
chromium-reviews, darin-cc_chromium.org, vikasjain.entc

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Gracefully handle multiple Flush/Reset/Decode with same id The DCHECKs don't trigger in release, and in any case it's a bit rude to have the renderer crash on a plugin that did the wrong thing, so send an error instead. BUG=None TEST=Pepper Flash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96649

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -16 lines)			Patch
M	ppapi/proxy/ppb_video_decoder_proxy.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	ppapi/shared_impl/video_decoder_impl.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ppapi/shared_impl/video_decoder_impl.cc	View	1 chunk	+11 lines, -7 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_video_decoder_impl.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Change committed as 96649

Expand Messages | Collapse Messages