Issue 7628011: Revert Revert 94812 - Formatting feature initial commit for ChromeOS Tree

Issue 7628011: Revert Revert 94812 - Formatting feature initial commit for ChromeOS Tree (Closed)

Created:
9 years, 4 months ago by tbarzic

Modified:
9 years, 4 months ago

Reviewers:
sidor, sidor.dev

CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert Revert 94812 - Formatting feature initial commit for ChromeOS Tree Previously reviewed and landed. Reverting to make merging next patch into M14 easier. Added formatting API for browser extension as well as event routing. Created a complete UI for formatting. This code depends on the following changes to libcros: http://gerrit.chromium.org/gerrit/#change,4446 BUG=chromium-os:4541, chromium-os:17071 TEST=Try to format removable media. Review URL: http://codereview.chromium.org/7471024 TBR=sidor@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95909 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96493

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+344 lines, -75 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_mount_library.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_mount_library.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mount_library.h	View		3 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/mount_library.cc	View	1 2 3 4	9 chunks	+105 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_event_router.h	View		3 chunks	+17 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View	1 2 3 4	10 chunks	+122 lines, -60 lines	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_api.h	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_api.cc	View	1 2 3 4 5 6	6 chunks	+31 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sidor.dev

9 years, 4 months ago (2011-08-11 22:46:53 UTC) #3

LGTM after small nit.

http://codereview.chromium.org/7628011/diff/6003/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/mount_library.cc (right):

http://codereview.chromium.org/7628011/diff/6003/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/mount_library.cc:188: "Device with this mount path
not found.");
One more space here?

Expand Messages | Collapse Messages