chromium-os:18602 - do not override shared setting on bad password

chromium-os:18602 - do not override shared setting on bad password


BUG=chromium-os:18602
TEST=See issue; test connection failure with shared option checked / unchecked.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96492

[Charlie Lee, 2011-08-11 23:50:59]

LGTM. Would it be better to also default the checkbox state (even if disabled)
to whatever the default share is for that network?

[stevenjb, 2011-08-12 00:20:55]

Right now we do not create a checkbox at all if a network already has a profile
type (i.e. is remembered). 
The default value is based on the type of network. I'm not sure if it would be
more helpful or more confusing to include the checkbox but disable it when we do
have a profile set.

[Charlie Lee, 2011-08-12 06:33:36]

I think it's good the way you have it. LGTM.

- Charlie


On Thu, Aug 11, 2011 at 5:20 PM, <stevenjb@chromium.org> wrote:

> Right now we do not create a checkbox at all if a network already has a
> profile
> type (i.e. is remembered).
> The default value is based on the type of network. I'm not sure if it would
> be
> more helpful or more confusing to include the checkbox but disable it when
> we do
> have a profile set.
>
>
>
>
http://codereview.chromium.**org/7628009/<http://codereview.chromium.org/7628...
>