Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 7628005: Fix flipped loop termination condition for width/height. (Closed)

Created:
9 years, 4 months ago by dcheng
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix flipped loop termination condition for width/height. BUG=92582 TEST=doesn't crash when you paste a non-32bpp image that's not square. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96668

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/base/clipboard/clipboard_win.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
Kind of an embarrassing bug to miss...
9 years, 4 months ago (2011-08-11 21:38:58 UTC) #1
tony
LGTM. I would use w and h for the loop variables. *shrug*
9 years, 4 months ago (2011-08-11 22:17:33 UTC) #2
dcheng
On 2011/08/11 22:17:33, tony wrote: > LGTM. I would use w and h for the ...
9 years, 4 months ago (2011-08-11 22:19:48 UTC) #3
tony
On 2011/08/11 22:19:48, dcheng wrote: > On 2011/08/11 22:17:33, tony wrote: > > LGTM. I ...
9 years, 4 months ago (2011-08-11 22:32:54 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-13 02:38:22 UTC) #5
Change committed as 96668

Powered by Google App Engine
This is Rietveld 408576698