Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 7627005: Fix a back forward bug in ChromeFrame reported on the field. The bug occurs when multiple (Closed)

Created:
9 years, 4 months ago by ananta
Modified:
9 years, 4 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix a back forward bug in ChromeFrame reported on the field. The bug occurs when multiple navigations are performed within IE + CF with some originating from IE and others within Chrome. The CF active document implementation had some code to reuse the active document instance in case a new CF navigation occurred within the current tab. This was for optimization, i.e. to ensure that we don't tear down and create a new instance of Chrome. This basically messed up the document destruction order causing the IE tab history to get populated with information coming from deleted active document instances at times. In any case this optimization is no longer necessary as we have a proxy cache maintained in the automation client in CF which ensures that we don't inadvarently tear down and create new chrome instances. Fixes bug http://code.google.com/p/chromium/issues/detail?id=90424 BUG=90424 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97177

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -91 lines) Patch
M chrome_frame/chrome_active_document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 5 chunks +8 lines, -56 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
9 years, 4 months ago (2011-08-17 01:01:31 UTC) #1
grt (UTC plus 2)
LGTM. I think thread_local.h is no longer needed by chrome_active_document.cc. Also, please re-try on win ...
9 years, 4 months ago (2011-08-17 09:51:41 UTC) #2
ananta
9 years, 4 months ago (2011-08-17 18:13:14 UTC) #3
http://codereview.chromium.org/7627005/diff/1/chrome_frame/chrome_active_docu...
File chrome_frame/chrome_active_document.cc (right):

http://codereview.chromium.org/7627005/diff/1/chrome_frame/chrome_active_docu...
chrome_frame/chrome_active_document.cc:29: #include
"base/threading/thread_local.h"
On 2011/08/17 09:51:41, grt wrote:
> I think this header is no longer needed.

Done. Removed a bunch of other unneeded headers as well.

Powered by Google App Engine
This is Rietveld 408576698