Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 7624052: Cleanup code used to diagnose and fix bug 81449. (Closed)

Created:
9 years, 4 months ago by apatrick_chromium
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Cleanup code used to diagnose and fix bug 81449. I think it is unlikely that CloseHandle was the function that was being hooked because it is called from so many other places without problems. I am assuming that TerminateProcess was being hooked. If the symptoms of 81449 return when this is landed, this patch can be reverted. BUG=81449 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97407

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -46 lines) Patch
M base/process_win.cc View 2 chunks +6 lines, -19 lines 0 comments Download
M base/task.h View 1 chunk +0 lines, -8 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/child_process_launcher.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apatrick_chromium
9 years, 4 months ago (2011-08-18 21:15:13 UTC) #1
darin (slow to review)
LGTM
9 years, 4 months ago (2011-08-18 21:20:05 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-19 01:36:38 UTC) #3
Change committed as 97407

Powered by Google App Engine
This is Rietveld 408576698