Issue 7624041: Fix initial prototype of WeakMap function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7624041: Fix initial prototype of WeakMap function. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger

Modified:
9 years, 3 months ago

Reviewers:
Kevin Millikin (Chromium), Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix initial prototype of WeakMap function. The bootstrapper accidentally overwrote the constructor property of the Object prototype because it used initial_object_prototype() as prototype for WeakMap. Unfortunately this is not possible for experimental natives because they are installed after the snapshot initialization finished. R=erik.corry@gmail.com TEST=mjsunit/mirror-object,mjsunit/harmony/weakmaps Committed: http://code.google.com/p/v8/source/detail?r=9067

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix grammar of comments. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	src/bootstrapper.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/weakmap.js	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
M	test/mjsunit/harmony/weakmaps.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/7624041/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/7624041/diff/1/src/bootstrapper.cc#newcode1163 src/bootstrapper.cc:1163: // Setup the call-as-function delegate. "Setup" is a ...

9 years, 3 months ago (2011-08-30 09:13:01 UTC) #1

Michael Starzinger

9 years, 3 months ago (2011-08-30 09:34:41 UTC) #2

Added new patch set.

http://codereview.chromium.org/7624041/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

http://codereview.chromium.org/7624041/diff/1/src/bootstrapper.cc#newcode1163
src/bootstrapper.cc:1163: // Setup the call-as-function delegate.
On 2011/08/30 09:13:01, Erik Corry wrote:
> "Setup" is a noun and "Set up" is a verb.  And one other place in this file.

Done.

http://codereview.chromium.org/7624041/diff/1/src/weakmap.js
File src/weakmap.js (right):

http://codereview.chromium.org/7624041/diff/1/src/weakmap.js#newcode90
src/weakmap.js:90: // Setup the constructor property on the WeakMap prototype
object.
On 2011/08/30 09:13:01, Erik Corry wrote:
> Setup -> Set up
> And 3 other places in this file.

Done.

Expand Messages | Collapse Messages