Treat files downloaded from the address bar as "always safe" (including extensions per discussion...

webkit/glue/resource_loader_bridge.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The intent of this file is to provide a type-neutral abstraction between
 // Chrome and WebKit for resource loading. This pure-virtual interface is
 // implemented by the embedder, which also provides a factory method Create
 // to instantiate this object.
 //
 // One of these objects will be created by WebKit for each request. WebKit
@@ skipping 12 matching lines @@
 #include "build/build_config.h"
 #if defined(OS_POSIX)
 #include "base/file_descriptor_posix.h"
 #endif
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/platform_file.h"
 #include "base/time.h"
 #include "base/values.h"
+#include "content/common/page_transition_types.h"

[darin (slow to review), 2011/08/18 04:21:01]

i see...

hmm, it certainly seems a bit wrong for this layer to need to know anything
about whether the request was initiated by typing in the omnibox.  we probably
do want to think about some way to push this through transparently. 
hmmmmmmmm...

[Peter Kasting, 2011/08/18 19:47:36]

I'm happy to do the gruntwork of whatever the right change is, but as I'm
touching classes here that I know nothing about, I'm not sure how to figure out
what should actually be done :).  Perhaps either you can think of something, or
direct me to someone with whom I should discuss this stuff?

 #include "googleurl/src/gurl.h"
 #include "net/base/host_port_pair.h"
 #include "net/url_request/url_request_status.h"
 #include "webkit/glue/resource_type.h"
 
 namespace net {
 class HttpResponseHeaders;
 }
 
 namespace webkit_glue {
@@ skipping 203 matching lines @@
 
     // True if the request was user initiated.
     bool has_user_gesture;
 
     // True if |frame_id| represents a main frame of a RenderView.
     bool is_main_frame;
 
     // Identifies the frame within the RenderView that sent the request.
     // -1 if unknown / invalid.
     int64 frame_id;
+
+    PageTransition::Type transition_type;
   };
 
   // See the SyncLoad method declared below.  (The name of this struct is not
   // suffixed with "Info" because it also contains the response data.)
   struct SyncLoadResponse : ResourceResponseInfo {
     SyncLoadResponse();
     ~SyncLoadResponse();
 
     // The response status.
     net::URLRequestStatus status;
@@ skipping 127 matching lines @@
   // construction must go through Create()
   ResourceLoaderBridge();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ResourceLoaderBridge);
 };
 
 }  // namespace webkit_glue
 
 #endif  // WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_