Keep normal popups opened from same-origin iframes in an extension process.

chrome/browser/extensions/app_process_apitest.cc

Index: chrome/browser/extensions/app_process_apitest.cc
diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc
index 7b56929dc7ebc77f6cf02c7ac36d4fed4ec744b4..957718fede1322cabfe78fe53dd68d4280e52514 100644
--- a/chrome/browser/extensions/app_process_apitest.cc
+++ b/chrome/browser/extensions/app_process_apitest.cc
@@ -133,8 +133,12 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_AppProcess) {
   WindowOpenHelper(browser(), host,
                    base_url.Resolve("path2/empty.html"), true);
   // This should open in a new process (i.e., false for the last argument).
+  // TODO(creis): Do we want the fix to change this behavior?  The alternative
+  // is to require the opener URL to be a non-extension URL in order to keep the

[Mihai Parparita -not on Chrome, 2011/08/17 20:33:09]

I think requiring this makes sense (it would still fix bug 92669, right?). That
seems closer to the ideal of having no non-app URLs in the app's process.

[Charlie Reis, 2011/08/17 21:55:24]

Agreed-- I've updated the logic so we don't affect this case.

+  // popup in process.  (I'm not sure whether we want an app page to open a
+  // non-app popup in the same process, just because they're same origin.)
   WindowOpenHelper(browser(), host,
-                   base_url.Resolve("path3/empty.html"), false);
+                   base_url.Resolve("path3/empty.html"), true);
 
   // Now let's have these pages navigate, into or out of the extension web
   // extent. They should switch processes.