Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 7624009: Original patch by rlarocque@chromium.org at http://codereview.chromium.org/7633077/ (Closed)

Created:
9 years, 4 months ago by Nicolas Zea
Modified:
9 years, 4 months ago
Reviewers:
CC:
chromium-reviews, GeorgeY, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, cbentzel+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., estade+watch_chromium.org, Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Original patch by rlarocque@chromium.org at http://codereview.chromium.org/7633077/ Fragment syncapi.h into sync/internal_api/* This commit splits syncapi.cc and syncapi.h into many files. Most of these files have been moved to the newly created chrome/browser/sync/internal_api. Each of the following classes now have their own .cc and .h files: - BaseNode - ReadNode - WriteNode - BaseTransaction - ReadTransaction - WriteTransaction - UserShare - SyncManager Functions formerly declared at file-scope in syncapi.cc and shared among several classes are now declared in engine/syncapi_internal.h. We intend to use DEPS rules to prevent these functions from being included in non-syncapi classes. Test classes closely related to syncapi.h classes have been moved from engine to internal_api. This change necessarily touches the #include lists for lots of files and some of the sources lists in .gyp. This change should have no effect on program behaviour. BUG=19878 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97238

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix windows build #

Patch Set 4 : Fix windows build pt2 #

Patch Set 5 : Fix windows build pt3 #

Patch Set 6 : Fix windows build pt4 #

Patch Set 7 : Fix windows build pt5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4709 lines, -5785 lines) Patch
M chrome/browser/sync/abstract_profile_sync_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/DEPS View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/all_status.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/change_reorder_buffer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/change_reorder_buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/engine/net/server_connection_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/nigori_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/sync/engine/read_node_mock.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/sync/engine/read_node_mock.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler.h View 1 chunk +3 lines, -4 lines 0 comments Download
D chrome/browser/sync/engine/syncapi.h View 1 chunk +0 lines, -1095 lines 0 comments Download
D chrome/browser/sync/engine/syncapi.cc View 1 chunk +0 lines, -3083 lines 0 comments Download
A chrome/browser/sync/engine/syncapi_internal.h View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/sync/engine/syncapi_internal.cc View 1 2 3 4 5 1 chunk +78 lines, -0 lines 0 comments Download
D chrome/browser/sync/engine/syncapi_mock.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/sync/engine/syncapi_unittest.cc View 1 chunk +0 lines, -1432 lines 0 comments Download
M chrome/browser/sync/glue/app_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/app_change_processor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/app_model_associator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_change_processor.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_change_processor.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_change_processor.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_change_processor.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/change_processor_mock.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_change_processor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/extension_model_associator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_sync.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_sync_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/session_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 2 3 4 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker_unittest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
A chrome/browser/sync/internal_api/DEPS View 1 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/README View 1 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/base_node.h View 1 1 chunk +224 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/base_node.cc View 1 1 chunk +298 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/base_transaction.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/base_transaction.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/read_node.h View 1 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/read_node.cc View 1 1 chunk +92 lines, -0 lines 0 comments Download
A + chrome/browser/sync/internal_api/read_node_mock.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
A + chrome/browser/sync/internal_api/read_node_mock.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/sync/internal_api/read_transaction.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/read_transaction.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/sync_manager.h View 1 2 1 chunk +546 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/sync_manager.cc View 1 1 chunk +2047 lines, -0 lines 0 comments Download
A + chrome/browser/sync/internal_api/syncapi_mock.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/internal_api/syncapi_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
A chrome/browser/sync/internal_api/user_share.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/user_share.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/write_node.h View 1 1 chunk +193 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/write_node.cc View 1 1 chunk +538 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/write_transaction.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/write_transaction.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/sync/js/DEPS View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/notifier/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/sessions/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/syncable/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_payload_map.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/sessions_ui.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +19 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/sync/engine/test_user_share.h View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698