Removed PPB_Graphics3D::GetString(). Versioning should be handled in pepper at a higher level.

Removed PPB_Graphics3D::GetString(). Versioning should be handled in pepper at a higher level.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97044

[piman, 2011-08-16 22:12:21]

Mmh, we need to keep at least the extensions. I don't think we can exactly map
the presence of an extension with the availability of a Pepper interface:
- some extensions may not map to an interface (e.g. an extension that just adds
enums, like GL_EXT_bgra)
- the list of extensions may depend on the context, but the availability of the
Pepper interface can't.

I'd argue that keeping GL_VENDOR and GL_RENDERER would be useful too. OpenGL
doesn't guarantee pixel-exact results in theory, but even in practice, there are
some differences between implementations. They are exposed to WebGL, why
shouldn't they be exposed to Pepper ?

[alokp, 2011-08-16 22:19:04]

On 2011/08/16 22:12:21, piman wrote:
> Mmh, we need to keep at least the extensions. I don't think we can exactly map
> the presence of an extension with the availability of a Pepper interface:
> - some extensions may not map to an interface (e.g. an extension that just
adds
> enums, like GL_EXT_bgra)
> - the list of extensions may depend on the context, but the availability of
the
> Pepper interface can't.
> 
> I'd argue that keeping GL_VENDOR and GL_RENDERER would be useful too. OpenGL
> doesn't guarantee pixel-exact results in theory, but even in practice, there
are
> some differences between implementations. They are exposed to WebGL, why
> shouldn't they be exposed to Pepper ?

I think you are referring to glGetString(). That is still supported. What I am
removing corresponds to eglQueryString().

[piman, 2011-08-16 22:21:51]

I see, then LGTM after you rev the interface.

http://codereview.chromium.org/7624003/diff/1/ppapi/c/dev/ppb_graphics_3d_dev.h
File ppapi/c/dev/ppb_graphics_3d_dev.h (right):

http://codereview.chromium.org/7624003/diff/1/ppapi/c/dev/ppb_graphics_3d_dev...
ppapi/c/dev/ppb_graphics_3d_dev.h:32: #define PPB_GRAPHICS_3D_DEV_INTERFACE
PPB_GRAPHICS_3D_DEV_INTERFACE_0_7
Please rev interface.