Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: base/values_unittest.cc

Issue 7623017: base: Remove CreateBinaryValue() function as it's redundant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values_unittest.cc
diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index 78163fd8ab597836877404901493f59256937624..b5bcbe1ae20ca612e16ade2152d0a715651d4be7 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -341,7 +341,7 @@ TEST(ValuesTest, DeepCopy) {
char* original_buffer = new char[42];
memset(original_buffer, '!', 42);
- BinaryValue* original_binary = Value::CreateBinaryValue(original_buffer, 42);
+ BinaryValue* original_binary = BinaryValue::Create(original_buffer, 42);
original_dict.Set("binary", original_binary);
ListValue* original_list = new ListValue();
@@ -533,7 +533,7 @@ TEST(ValuesTest, DeepCopyCovariantReturnTypes) {
char* original_buffer = new char[42];
memset(original_buffer, '!', 42);
- BinaryValue* original_binary = Value::CreateBinaryValue(original_buffer, 42);
+ BinaryValue* original_binary = BinaryValue::Create(original_buffer, 42);
original_dict.Set("binary", original_binary);
ListValue* original_list = new ListValue();
« no previous file with comments | « base/values.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698