Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2515)

Unified Diff: base/values.h

Issue 7623017: base: Remove CreateBinaryValue() function as it's redundant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index bf54bd1444d105ac153996d67a7ab0d40c2ee55f..8f427ab9f0a8dd60bf44bd1450cdad9a233d0544 100644
--- a/base/values.h
+++ b/base/values.h
@@ -76,10 +76,6 @@ class BASE_EXPORT Value {
static StringValue* CreateStringValue(const std::string& in_value);
static StringValue* CreateStringValue(const string16& in_value);
- // This one can return NULL if the input isn't valid. If the return value
- // is non-null, the new object has taken ownership of the buffer pointer.
- static BinaryValue* CreateBinaryValue(char* buffer, size_t size);
-
// Returns the type of the value stored by the current Value object.
// Each type will be implemented by only one subclass of Value, so it's
// safe to use the ValueType to determine whether you can cast from
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698