Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: base/values.cc

Issue 7623017: base: Remove CreateBinaryValue() function as it's redundant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/values.h ('k') | base/values_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 10
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // static 89 // static
90 StringValue* Value::CreateStringValue(const std::string& in_value) { 90 StringValue* Value::CreateStringValue(const std::string& in_value) {
91 return new StringValue(in_value); 91 return new StringValue(in_value);
92 } 92 }
93 93
94 // static 94 // static
95 StringValue* Value::CreateStringValue(const string16& in_value) { 95 StringValue* Value::CreateStringValue(const string16& in_value) {
96 return new StringValue(in_value); 96 return new StringValue(in_value);
97 } 97 }
98 98
99 // static
100 BinaryValue* Value::CreateBinaryValue(char* buffer, size_t size) {
101 return BinaryValue::Create(buffer, size);
102 }
103
104 bool Value::GetAsBoolean(bool* out_value) const { 99 bool Value::GetAsBoolean(bool* out_value) const {
105 return false; 100 return false;
106 } 101 }
107 102
108 bool Value::GetAsInteger(int* out_value) const { 103 bool Value::GetAsInteger(int* out_value) const {
109 return false; 104 return false;
110 } 105 }
111 106
112 bool Value::GetAsDouble(double* out_value) const { 107 bool Value::GetAsDouble(double* out_value) const {
113 return false; 108 return false;
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
903 if (lhs_it != end() || rhs_it != other_list->end()) 898 if (lhs_it != end() || rhs_it != other_list->end())
904 return false; 899 return false;
905 900
906 return true; 901 return true;
907 } 902 }
908 903
909 ValueSerializer::~ValueSerializer() { 904 ValueSerializer::~ValueSerializer() {
910 } 905 }
911 906
912 } // namespace base 907 } // namespace base
OLDNEW
« no previous file with comments | « base/values.h ('k') | base/values_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698