Issue 7623013: Test (and fix) all exception paths that can occur with proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7623013: Test (and fix) all exception paths that can occur with proxies. (Closed)

Created:
9 years, 4 months ago by rossberg

Modified:
9 years, 3 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Test (and fix) all exception paths that can occur with proxies. R=kmillikin@chromium.org BUG=v8:1543 TEST= Committed: http://code.google.com/p/v8/source/detail?r=9261

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+684 lines, -94 lines)			Patch
	M	src/objects.cc	View		5 chunks	+5 lines, -0 lines	0 comments	Download
	M	test/mjsunit/harmony/proxies.js	View		31 chunks	+679 lines, -94 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/7623013/diff/1/test/mjsunit/harmony/proxies.js File test/mjsunit/harmony/proxies.js (right): http://codereview.chromium.org/7623013/diff/1/test/mjsunit/harmony/proxies.js#newcode168 test/mjsunit/harmony/proxies.js:168: TestWithProxies(TestGetThrow2, handler) This is impressively indirect.

9 years, 3 months ago (2011-09-07 12:51:36 UTC) #2

rossberg

9 years, 3 months ago (2011-09-07 14:59:33 UTC) #3

http://codereview.chromium.org/7623013/diff/1/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7623013/diff/1/test/mjsunit/harmony/proxies.js...
test/mjsunit/harmony/proxies.js:168: TestWithProxies(TestGetThrow2, handler)
On 2011/09/07 12:51:36, Kevin Millikin wrote:
> This is impressively indirect.

And still there is far too much duplication in the tests. I feel an urge to add
at least one further level of indirection... :)

Expand Messages | Collapse Messages