Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 7623006: Add preference for managed notifications setting. (Closed)

Created:
9 years, 4 months ago by markusheintz_
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add preference for managed notifications setting. BUG=63190 TEST=host_content_settings_map_unittest.cc, content_settings_policy_provider_unittest.cc desktop_notification_service_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96548

Patch Set 1 #

Patch Set 2 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/app/policy/policy_templates.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_notification_provider.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.cc View 4 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
markusheintz_
Pls review my CL thanks.
9 years, 4 months ago (2011-08-11 11:51:07 UTC) #1
Mattias Nissler (ping if slow)
9 years, 4 months ago (2011-08-11 13:53:36 UTC) #2
LGTM. Any thoughts on backwards compatibility? Have we changed the name? Do we
need to migrate?

Powered by Google App Engine
This is Rietveld 408576698