Issue 7622012: Removal of Profile from content part 8.

Issue 7622012: Removal of Profile from content part 8. (Closed)

Created:
9 years, 4 months ago by Avi (use Gerrit)

Modified:
9 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Removal of Profile from content part 8. BUG=76788 TEST=no change visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96554

Patch Set 1 #

Patch Set 2 : fix #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
M	chrome/browser/extensions/extension_webnavigation_api.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_manager_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/content_notification_types.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	content/common/notification_service.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

This is about it except for all the uses of Profile::GetDefaultRequestContext. I might have to ...

9 years, 4 months ago (2011-08-11 15:17:02 UTC) #1

Avi (use Gerrit)

On 2011/08/11 15:17:02, Avi wrote: > This is about it except for all the uses ...

9 years, 4 months ago (2011-08-11 15:31:45 UTC) #2

jam

On 2011/08/11 15:17:02, Avi wrote: > This is about it except for all the uses ...

9 years, 4 months ago (2011-08-11 18:52:02 UTC) #5

Avi (use Gerrit)

Profile::GetDefaultRequestContext is static. Any static function on BrowserContext would have to somehow know about Profile, ...

9 years, 4 months ago (2011-08-11 18:56:39 UTC) #6

jam

I see. How about ContentBrowserContext::GetDefaultBrowserContext for now? On Thu, Aug 11, 2011 at 11:54 AM, ...

9 years, 4 months ago (2011-08-11 19:03:45 UTC) #7

jam

9 years, 4 months ago (2011-08-15 17:17:14 UTC) #8

sgtm, and then the bug you filed can reference that as well

On 2011/08/11 19:03:45, John Abd-El-Malek wrote:
> I see. How about ContentBrowserContext::GetDefaultBrowserContext for now?
> 
> On Thu, Aug 11, 2011 at 11:54 AM, <mailto:avi@chromium.org> wrote:
> 
> > Profile::**GetDefaultRequestContext is static. Any static function on
> > BrowserContext would have to somehow know about Profile, thus preventing
> > the
> > goal of ridding content of Profile.
> >
> >
> >
>
http://codereview.chromium.**org/7622012/%3Chttp://codereview.chromium.org/76...>
> >

Expand Messages | Collapse Messages