Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 7622006: Removed some arbitrary size restrictions when disassembling generated code. (Closed)

Created:
9 years, 4 months ago by Sven Panne
Modified:
9 years, 4 months ago
Reviewers:
Erik Corry, danno
CC:
v8-dev
Visibility:
Public.

Description

Removed some arbitrary size restrictions when disassembling generated code. We output line-by-line now, this avoids hitting StringBuffer ASSERTs when disassembling huge code objects. Committed: http://code.google.com/p/v8/source/detail?r=8897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M src/disassembler.cc View 4 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 4 months ago (2011-08-11 12:11:28 UTC) #1
danno
9 years, 4 months ago (2011-08-11 12:22:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698