Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 7622005: Ensure that incognito profiles are correctly destroyed when all incognito windows belonging to a ... (Closed)

Created:
9 years, 4 months ago by Miranda Callahan
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Ensure that incognito profiles are correctly destroyed when all incognito windows belonging to a given profile have been closed. BUG=92437 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96549

Patch Set 1 #

Patch Set 2 : add task manager usage #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_list.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Miranda Callahan
Joao, could you review this small change, as you were instrumental in diagnosis? :-) dominich, ...
9 years, 4 months ago (2011-08-11 10:52:09 UTC) #1
Joao da Silva
LGTM! :-)
9 years, 4 months ago (2011-08-11 11:25:24 UTC) #2
dominich
LGTM
9 years, 4 months ago (2011-08-11 14:00:19 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 4 months ago (2011-08-11 18:03:14 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 13:02:26 UTC) #5
Change committed as 96549

Powered by Google App Engine
This is Rietveld 408576698