chrome/renderer/print_web_view_helper_mac.mm - Issue 7621087: Print Preview: Go from event driven print preview back to print preview with sync messages. The s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_mac.mm

Issue 7621087: Print Preview: Go from event driven print preview back to print preview with sync messages. The s... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: remove requested_page Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/print_web_view_helper.cc ('K') | « chrome/renderer/print_web_view_helper_linux.cc ('k') | chrome/renderer/print_web_view_helper_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/print_web_view_helper_mac.mm

===================================================================

--- chrome/renderer/print_web_view_helper_mac.mm (revision 97484)

+++ chrome/renderer/print_web_view_helper_mac.mm (working copy)

@@ -59,7 +59,7 @@

Send(new PrintHostMsg_DidPrintPage(routing_id(), page_params));

}

-void PrintWebViewHelper::RenderPreviewPage(int page_number) {

+bool PrintWebViewHelper::RenderPreviewPage(int page_number) {

float scale_factor = print_preview_context_.frame()->getPrintPageShrink(0);

PrintMsg_Print_Params printParams = print_preview_context_.print_params();

gfx::Rect content_area(printParams.margin_left, printParams.margin_top,

@@ -73,8 +73,7 @@

if (print_preview_context_.IsModifiable()) {

draft_metafile.reset(new printing::PreviewMetafile);

if (!draft_metafile->Init()) {

- DidFinishPrinting(FAIL_PREVIEW);

- return;

+ return false;

}

initial_render_metafile = draft_metafile.get();

}

@@ -118,7 +117,7 @@

#endif

}

- PreviewPageRendered(page_number, draft_metafile.get());

+ return PreviewPageRendered(page_number, draft_metafile.get());

}

void PrintWebViewHelper::RenderPage(

« chrome/renderer/print_web_view_helper.cc ('K') | « chrome/renderer/print_web_view_helper_linux.cc ('k') | chrome/renderer/print_web_view_helper_win.cc » ('j') | no next file with comments »