Print Preview: Go from event driven print preview back to print preview with sync messages. The s...

chrome/renderer/print_web_view_helper.h

Index: chrome/renderer/print_web_view_helper.h
===================================================================
--- chrome/renderer/print_web_view_helper.h	(revision 97484)
+++ chrome/renderer/print_web_view_helper.h	(working copy)
@@ -141,19 +141,14 @@
   // Initialize the print preview document.
   bool CreatePreviewDocument();
 
-  // Continue generating the print preview. |requested_preview_page_index|
-  // specifies the browser requested preview page index. It is 1-based or
-  // |printing::INVALID_PAGE_INDEX| to continue with next page.
-  void OnContinuePreview(int requested_preview_page_index);
   // Renders a print preview page. |page_number| is 0-based.
-  void RenderPreviewPage(int page_number);
+  // Returns true if print preview should continue, false on
+  // cancellation / failure.
+  bool RenderPreviewPage(int page_number);
+
   // Finalize the print preview document.
   bool FinalizePreviewDocument();
 
-  // Abort the preview to put |print_preview_context_| into the 'UNINITIALIZED'
-  // state.
-  void OnAbortPreview();
-
   // Print / preview the node under the context menu.
   void OnPrintNodeUnderContextMenu();
 
@@ -171,7 +166,6 @@
     OK,
     FAIL_PRINT,
     FAIL_PREVIEW,
-    ABORT_PREVIEW,
   };
 
   // Notification when printing is done - signal tear-down/free resources.
@@ -190,11 +184,6 @@
       WebKit::WebNode* node,
       scoped_ptr<PrepareFrameAndViewForPrint>* prepare);
 
-  // Parse the request id out of |job_settings| and store it in |params|.
-  // Returns false on failure.
-  bool UpdatePrintSettingsRequestId(const base::DictionaryValue& job_settings,
-                                    PrintMsg_Print_Params* params);
-
   // Update the current print settings with new |job_settings|. |job_settings|
   // dictionary contains print job details such as printer name, number of
   // copies, page range, etc.
@@ -307,10 +296,13 @@
 
   void RequestPrintPreview();
 
-  // Notify the browser a print preview page has been rendered.
+  // Notifies the browser a print preview page has been rendered.
   // |page_number| is 0-based or |printing::INVALID_PAGE_INDEX| to check
   // for pending preview requests.
-  void PreviewPageRendered(int page_number, printing::Metafile* metafile);
+  // For a valid |page_number|, |metafile| is the rendered page.

[kmadhusu, 2011/08/19 19:51:03]

For a valid |page_number|,
If the initiator is modifiable, |metafile| is the rendered page. 

If the initiator tab is non-modifiable, |metafile| is NULL.

[Lei Zhang, 2011/08/19 22:50:28]

Done.

+  // Returns true if print preview should continue, false on
+  // cancellation / failure.
+  bool PreviewPageRendered(int page_number, printing::Metafile* metafile);
 
   WebKit::WebView* print_web_view_;
 
@@ -362,13 +354,9 @@
     // Cleanup after print preview fails.
     void Failed();
 
-    // Abort the print preview.
-    void Abort();
-
     // Helper functions
     int GetNextPageNumber();
     bool IsReadyToRender() const;
-    bool IsBusy() const;
     bool IsModifiable() const;
 
     // Getters
@@ -405,12 +393,9 @@
     int actual_page_count_;
 
     // The current page to render.
-    int current_page_number_;
+    int current_page_index_;
 
-    // |rendered_pages_| tracks which pages need to be printed as well as
-    // the page slot it should be printed in. See GetPageSlotForPage.
-    typedef std::pair<bool, int> PreviewPageInfo;
-    std::vector<PreviewPageInfo> rendered_pages_;
+    std::vector<int> pages_to_render_;
 
     base::TimeDelta document_render_time_;
     base::TimeTicks begin_time_;