Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: chrome/renderer/print_web_view_helper_browsertest.cc

Issue 7621087: Print Preview: Go from event driven print preview back to print preview with sync messages. The s... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: merge, undo print preview id change Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/print_web_view_helper_browsertest.cc
===================================================================
--- chrome/renderer/print_web_view_helper_browsertest.cc (revision 97706)
+++ chrome/renderer/print_web_view_helper_browsertest.cc (working copy)
@@ -41,6 +41,7 @@
dict->SetInteger(printing::kSettingDuplexMode, printing::SIMPLEX);
dict->SetInteger(printing::kSettingCopies, 1);
dict->SetString(printing::kSettingDeviceName, "dummy");
+ dict->SetString(printing::kPreviewUIAddr, "0xb33fbeef");
dict->SetInteger(printing::kPreviewRequestID, 12345);
dict->SetBoolean(printing::kIsFirstRequest, true);
dict->SetBoolean(printing::kSettingHeaderFooterEnabled, false);
@@ -346,13 +347,6 @@
CreatePrintSettingsDictionary(&dict);
PrintWebViewHelper::Get(view_)->OnPrintPreview(dict);
- // Need to finish simulating print preview.
- // Generate the page and finalize it.
- PrintWebViewHelper::Get(view_)->OnContinuePreview(
- printing::INVALID_PAGE_INDEX);
- PrintWebViewHelper::Get(view_)->OnContinuePreview(
- printing::INVALID_PAGE_INDEX);
-
EXPECT_EQ(0, render_thread_.print_preview_pages_remaining());
VerifyPrintPreviewFailed(false);
VerifyPrintPreviewGenerated(true);

Powered by Google App Engine
This is Rietveld 408576698