Merge the plugin and impl side of the audio config and input event resources.

Merge the plugin and impl side of the audio config and input event resources.

Now that we have a unified resource system, we no longer need the duplication
on both sides of the proxy. This resource is now implemented entirely in
shared_impl.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98185

[yzshen1, 2011-08-22 17:36:44]

On 2011/08/18 18:07:50, brettw wrote:

LGTM

Just a few minor issues. Please fix them before submitting the change.

[yzshen1, 2011-08-22 17:37:00]

http://codereview.chromium.org/7621070/diff/3001/ppapi/proxy/ppb_audio_config...
File ppapi/proxy/ppb_audio_config_proxy.cc (left):

http://codereview.chromium.org/7621070/diff/3001/ppapi/proxy/ppb_audio_config...
ppapi/proxy/ppb_audio_config_proxy.cc:70: PP_Resource
PPB_AudioConfig_Proxy::CreateProxyResource(
You could also remove the declaration in the .h file.

http://codereview.chromium.org/7621070/diff/3001/ppapi/proxy/resource_creatio...
File ppapi/proxy/resource_creation_proxy.cc (right):

http://codereview.chromium.org/7621070/diff/3001/ppapi/proxy/resource_creatio...
ppapi/proxy/resource_creation_proxy.cc:28: #include
"ppapi/proxy/ppb_input_event_proxy.h"
Do you still need this one?

http://codereview.chromium.org/7621070/diff/3001/ppapi/shared_impl/audio_conf...
File ppapi/shared_impl/audio_config_impl.h (right):

http://codereview.chromium.org/7621070/diff/3001/ppapi/shared_impl/audio_conf...
ppapi/shared_impl/audio_config_impl.h:37: AudioConfigImpl(const HostResource&
host_resource);  // Proxy constructor.
It may be good to mark them as 'explicit'.