Fix sync test crashing when multiprofiles are enabled on Mac.

Fix sync test crashing when multiprofiles are enabled on Mac.

BUG=93278
TEST=sync_integration_tests all work fine when multiprofiles are enabled by default.

[Miranda Callahan, 2011-08-18 14:20:07]

Two problems here: once multiprofiles are enabled, profiles need to be plugged
into a couple of data structures in the ProfileManager.  Once the ProfileManager
takes charge of the Profiles, it will also take charge of deleting them -- we
shouldn't store them in a scoped structure.

[Miranda Callahan, 2011-08-18 14:59:21]

On 2011/08/18 14:20:07, Miranda Callahan wrote:
> Two problems here: once multiprofiles are enabled, profiles need to be plugged
> into a couple of data structures in the ProfileManager.  Once the
ProfileManager
> takes charge of the Profiles, it will also take charge of deleting them -- we
> shouldn't store them in a scoped structure.

Should be ready for review now.

[Robert Sesek, 2011-08-18 15:00:28]

http://codereview.chromium.org/7621066/diff/3004/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.h (right):

http://codereview.chromium.org/7621066/diff/3004/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.h:170: // Register and add testing
profile to the ProfileManager.
Add a scary comment about how this is only for use in tests.

http://codereview.chromium.org/7621066/diff/3004/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.h:178: friend class
ExtensionEventRouterForwarderTest;
Update this guy to use RegisterTestingProfile so you can un-friend him?

[Miranda Callahan, 2011-08-18 15:08:35]

http://codereview.chromium.org/7621066/diff/3004/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.h (right):

http://codereview.chromium.org/7621066/diff/3004/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.h:170: // Register and add testing
profile to the ProfileManager.
On 2011/08/18 15:00:28, rsesek wrote:
> Add a scary comment about how this is only for use in tests.

Done.

http://codereview.chromium.org/7621066/diff/3004/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.h:178: friend class
ExtensionEventRouterForwarderTest;
On 2011/08/18 15:00:28, rsesek wrote:
> Update this guy to use RegisterTestingProfile so you can un-friend him?

Done.

[Robert Sesek, 2011-08-18 15:10:24]

LGTM!

[Raghu Simha, 2011-08-18 16:56:19]

Changes to live_sync_test LGTM. Thanks for making these changes!

[Robert Sesek, 2011-09-09 18:49:21]

Ping on this? FYI the files have moved to
chrome/browser/sync/test/integration/sync_test.h