Restoring a session should restore window minimization state

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 59906b5e50712dd6d2da908effaad62488f99471..bd6b72c27ccd4f2e8231ecb5a4fa63e2c7e98fb6 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -783,6 +783,12 @@ bool BrowserView::IsMaximized() const {
   return frame_->IsMaximized();
 }
 
+bool BrowserView::IsMinimized() const {
+  // TODO(dhollowa): Add support for session restore of minimized state.
+  // http://crbug.com/43274
+  return false;

[sky, 2011/08/19 16:59:54]

You should be able to call into frame_->IsMinimized() here.

[dhollowa, 2011/08/19 17:58:53]

Yes, I'd like to wait until I have both save/restore working before turning this
on.

On 2011/08/19 16:59:54, sky wrote:

+}
+
 void BrowserView::SetFullscreen(bool fullscreen) {
   if (IsFullscreen() == fullscreen)
     return;  // Nothing to do.
@@ -1628,7 +1634,9 @@ void BrowserView::SaveWindowPlacement(const gfx::Rect& bounds,
   // which we want to ignore.
   if (!IsFullscreen() && browser_->ShouldSaveWindowPlacement()) {
     WidgetDelegate::SaveWindowPlacement(bounds, maximized);
-    browser_->SaveWindowPlacement(bounds, maximized);
+    browser_->SaveWindowPlacement(bounds,

[sky, 2011/08/19 16:59:54]

Can you add a TODO to update this as well.

[dhollowa, 2011/08/19 17:58:53]

Done.

+                                  maximized ? ui::SHOW_STATE_MAXIMIZED :
+                                              ui::SHOW_STATE_NORMAL);
   }
 }
 
@@ -1672,7 +1680,7 @@ bool BrowserView::GetSavedWindowBounds(gfx::Rect* bounds) const {
 }
 
 bool BrowserView::GetSavedMaximizedState(bool* maximized) const {
-  *maximized = browser_->GetSavedMaximizedState();
+  *maximized = browser_->GetSavedWindowShowState() == ui::SHOW_STATE_MAXIMIZED;

[sky, 2011/08/19 16:59:54]

And a TODO here too.

[dhollowa, 2011/08/19 17:58:53]

Done.

   return true;
 }