Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8090)

Unified Diff: chrome/common/extensions/extension.cc

Issue 7621032: Initial inline web store install bindings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 1b623538d0ce3e7064f8213bb0938268844e8943..6e5c0f29d89363d2a3f7a5aee95d4e0ca7290236 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -2338,6 +2338,11 @@ std::string Extension::ChromeStoreLaunchURL() {
return gallery_prefix;
}
+// static
+std::string Extension::ChromeStoreItemDetailURLPrefix() {
+ return ChromeStoreLaunchURL() + "/detail/";
+}
+
GURL Extension::GetHomepageURL() const {
if (homepage_url_.is_valid())
return homepage_url_;
@@ -2345,10 +2350,7 @@ GURL Extension::GetHomepageURL() const {
if (!UpdatesFromGallery())
return GURL();
- // TODO(erikkay): This may not be entirely correct with the webstore.
- // I think it will have a mixture of /extensions/detail and /webstore/detail
- // URLs. Perhaps they'll handle this nicely with redirects?
- GURL url(ChromeStoreLaunchURL() + std::string("/detail/") + id());
+ GURL url(ChromeStoreItemDetailURLPrefix() + id());
return url;
}

Powered by Google App Engine
This is Rietveld 408576698