chrome/test/data/extensions/api_test/webstore_inline_install/install.html - Issue 7621032: Initial inline web store install bindings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/webstore_inline_install/install.html

Issue 7621032: Initial inline web store install bindings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link rel="chrome-webstore-item" href="http://cws.com/detail/abc">
	Aaron Boodman 2011/08/17 04:53:03 Why specify the URL just to take it apart in the r Why specify the URL just to take it apart in the renderer, and send it up to the browser. Why not just specify the ID only? Mihai Parparita -not on Chrome 2011/08/17 23:00:16 Having a full URL seems cleaner from a web standar Show quoted text On 2011/08/17 04:53:03, Aaron Boodman wrote: > Why specify the URL just to take it apart in the renderer, and send it up to the > browser. Why not just specify the ID only? Having a full URL seems cleaner from a web standards perspective (http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#at...).
	5 </head>

	6 <body>

	7 <script>

	8 function runTest() {

	9 chrome.webstore.install();
	Aaron Boodman 2011/08/17 04:53:03 Do we need both chrome.webstore.install() and chro Do we need both chrome.webstore.install() and chrome.app.install()? Did you all discuss combining them? Also, did you discuss passing the URL to install() directly? Mihai Parparita -not on Chrome 2011/08/17 23:00:16 I don't seem much overlap in the implementation as Show quoted text On 2011/08/17 04:53:03, Aaron Boodman wrote: > Do we need both chrome.webstore.install() and chrome.app.install()? Did you all > discuss combining them? I don't seem much overlap in the implementation as things currently stand (chrome.app.install has to fetch the CRX-less manifest, whereas chrome.webstore.install will need to talk to CWS). I also didn't want to have "app" in the name, since the intent is to allow this to prompt for installation of extensions and themes too. Show quoted text > Also, did you discuss passing the URL to install() directly? I think there's some value in having the <link> tag for crawl reasons. For cases where the page has multiple <link> tags, https://docs.google.com/a/google.com/document/d/1dlADtMCDK-i1EMIw0ECvvAoCtw9h... mentions allowing an optional ID parameter to specify which should be installed.
	10 window.domAutomationController.send(true);

	11 }

	12 </script>

	13

	14 </body>

	15 </html>

OLD	NEW