Issue 7621028: Add some heapcheck suppressions after some download code refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7621028: Add some heapcheck suppressions after some download code refactoring. (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add some heapcheck suppressions after some download code refactoring. BUG=93006 TBR=timur Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97057

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

9 years, 4 months ago (2011-08-17 08:08:56 UTC) #2

LGTM
You've forgotten about Valgrind bots this time:
http://src.chromium.org/viewvc/chrome?view=rev&revision=97112

Is it hard to fix all those bug_93006 leaks instead of suppressing each new
test?

Expand Messages | Collapse Messages