Issue 7621026: Linux: fix a missing dereference that prevented GNOME 3 proxy settings from being queried.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7621026: Linux: fix a missing dereference that prevented GNOME 3 proxy settings from being queried. (Closed)

Created:
9 years, 4 months ago by Mike Mammarella

Modified:
9 years, 4 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Linux: fix an incorrect cast and missing dereference that prevented GNOME 3 proxy settings from being queried. This should be merged into both beta and stable. BUG=91744 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97020

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/proxy/proxy_config_service_linux.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

9 years, 4 months ago (2011-08-16 20:59:10 UTC) #2

LGTM

http://codereview.chromium.org/7621026/diff/1/net/proxy/proxy_config_service_...
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/7621026/diff/1/net/proxy/proxy_config_service_...
net/proxy/proxy_config_service_linux.cc:558: const gchar* const* schemas =
g_settings_list_schemas();
I can see how this came about, since the double star in the type is hard to see.
 Too bad we can't fix that.

Expand Messages | Collapse Messages