Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7621010: Never submit: tentative Pepper IME. (Closed)

Created:
9 years, 4 months ago by kochi
Modified:
9 years, 2 months ago
Reviewers:
kinaba
Visibility:
Public.

Description

THIS ONE IS OBSOLETE: SEE http://codereview.chromium.org/7977017/ Never submit: tentative Pepper IME. This is tentative. BUG= TEST=

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : snapshot #

Patch Set 6 : snapshot #

Total comments: 4

Patch Set 7 : snapshot #

Patch Set 8 : snapshot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2089 lines, -64 lines) Patch
M content/renderer/pepper_plugin_delegate_impl.h View 1 2 3 4 5 4 chunks +22 lines, -3 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 4 5 3 chunks +87 lines, -4 lines 0 comments Download
M content/renderer/render_view.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view.cc View 1 2 3 4 5 6 7 2 chunks +27 lines, -33 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 2 chunks +16 lines, -14 lines 0 comments Download
A ppapi/api/dev/ppb_text_input_dev.idl View 1 2 3 4 5 6 7 1 chunk +65 lines, -0 lines 0 comments Download
M ppapi/api/ppb_input_event.idl View 1 2 3 4 5 6 7 3 chunks +105 lines, -2 lines 0 comments Download
A ppapi/c/dev/ppb_text_input_dev.h View 1 2 3 4 5 6 7 1 chunk +92 lines, -0 lines 0 comments Download
M ppapi/c/ppb_input_event.h View 1 2 3 4 5 6 7 4 chunks +105 lines, -2 lines 0 comments Download
A ppapi/cpp/dev/text_input_dev.h View 1 2 3 4 5 6 1 chunk +33 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/text_input_dev.cc View 1 2 3 4 5 6 7 1 chunk +57 lines, -0 lines 0 comments Download
M ppapi/cpp/input_event.h View 1 2 3 4 5 6 7 2 chunks +41 lines, -0 lines 0 comments Download
M ppapi/cpp/input_event.cc View 1 2 3 4 5 6 7 2 chunks +63 lines, -0 lines 0 comments Download
A ppapi/examples/ime/ime.cc View 1 2 3 4 5 6 7 1 chunk +582 lines, -0 lines 0 comments Download
A ppapi/examples/ime/ime.html View 1 2 3 4 5 6 7 1 chunk +39 lines, -0 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 2 3 4 5 6 3 chunks +3 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_id.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 4 5 6 4 chunks +19 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_input_event_proxy.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppb_input_event_proxy.cc View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_text_input_proxy.h View 1 2 3 4 5 6 7 1 chunk +62 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_text_input_proxy.cc View 1 2 3 4 5 6 7 1 chunk +121 lines, -0 lines 0 comments Download
M ppapi/shared_impl/function_group_base.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/input_event_impl.h View 1 2 3 4 5 6 3 chunks +9 lines, -0 lines 0 comments Download
M ppapi/shared_impl/input_event_impl.cc View 1 2 3 4 5 6 2 chunks +23 lines, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_input_event_api.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_input_event_thunk.cc View 1 2 3 4 5 6 2 chunks +62 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_text_input_api.h View 1 2 3 4 5 6 7 1 chunk +34 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_text_input_thunk.cc View 1 2 3 4 5 6 7 1 chunk +55 lines, -0 lines 0 comments Download
M ppapi/thunk/thunk.h View 1 2 3 4 5 6 4 chunks +5 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 3 4 5 6 3 chunks +5 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 4 5 6 chunks +40 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 4 5 6 5 chunks +143 lines, -1 line 0 comments Download
A webkit/plugins/ppapi/ppb_text_input_impl.h View 1 2 3 4 5 6 7 1 chunk +45 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_text_input_impl.cc View 1 2 3 4 5 6 7 1 chunk +64 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.cc View 1 2 3 4 5 6 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
kochi
9 years, 3 months ago (2011-09-09 07:58:58 UTC) #1 
Thanks for making this happen!

Just a first-pass comments.

http://codereview.chromium.org/7621010/diff/18001/ppapi/c/ppb_input_event.h
File ppapi/c/ppb_input_event.h (right):

http://codereview.chromium.org/7621010/diff/18001/ppapi/c/ppb_input_event.h#n...
ppapi/c/ppb_input_event.h:743: uint32_t (*GetTargetSegment)(PP_Resource
composition_event);
Could you change this to GetSelectionRange()?
probably the prototype is
void (*GetSelectionRange)(PP_Resource composition_event, uint32_t* start,
uint32_t* end);

http://codereview.chromium.org/7621010/diff/18001/ppapi/cpp/input_event.h
File ppapi/cpp/input_event.h (right):

http://codereview.chromium.org/7621010/diff/18001/ppapi/cpp/input_event.h#new...
ppapi/cpp/input_event.h:337: uint32_t GetTargetSegment() const;
std::pair<uint32_t> GetSelectionRange() const;

or shall we create PP_Range type?

http://codereview.chromium.org/7621010/diff/18001/ppapi/examples/ime/ime.cc
File ppapi/examples/ime/ime.cc (right):

http://codereview.chromium.org/7621010/diff/18001/ppapi/examples/ime/ime.cc#n...
ppapi/examples/ime/ime.cc:120: bool onthespot) {
onthespot param not used.

http://codereview.chromium.org/7621010/diff/18001/ppapi/examples/ime/ime.cc#n...
ppapi/examples/ime/ime.cc:391: int rx =
font.MeasureText(pp::TextRun_Dev(str.substr(0,r).c_str()));
80 column

Powered by Google App Engine
This is Rietveld 408576698