Issue 7621002: Send only one byte of data in the first CBC encrypted aplication data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7621002: Send only one byte of data in the first CBC encrypted aplication data (Closed)

Created:
9 years, 4 months ago by wtc

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, agl

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Send only one byte of data in the first CBC encrypted aplication data record. This randomizes the IV in a backward compatible manner. R=agl@chromium.org BUG=87159 TEST=HTTPS sites continue to work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97269

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove TABs at the end of lines. #

Patch Set 3 : Remove space at the end of a line. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -2 lines)			Patch
M	net/socket/ssl_client_socket_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/third_party/nss/README.chromium	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/third_party/nss/patches/applypatches.sh	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/third_party/nss/patches/cbcrandomiv.patch	View	1 2	1 chunk	+59 lines, -0 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3con.c	View	1 2	3 chunks	+30 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM http://codereview.chromium.org/7621002/diff/1/net/third_party/nss/ssl/ssl3con.c File net/third_party/nss/ssl/ssl3con.c (right): http://codereview.chromium.org/7621002/diff/1/net/third_party/nss/ssl/ssl3con.c#newcode2351 net/third_party/nss/ssl/ssl3con.c:2351: ssl_GetSpecReadLock(ss); nit: stray tab on the end of ...

9 years, 4 months ago (2011-08-11 04:28:03 UTC) #2

Change committed as 97269

Expand Messages | Collapse Messages