Issue 7620016: Fix 3D-CSS transform printing - proxy device origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7620016: Fix 3D-CSS transform printing - proxy device origin. (Closed)

Created:
9 years, 4 months ago by vandebo (ex-Chrome)

Modified:
9 years, 4 months ago

Reviewers:
Chris Guillory, commit-bot: I haz the power, reed1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix 3D-CSS transform printing - proxy device origin. Depends on Skia r2108,2116 BUG=82746 TEST=print http://www.webkit.org/blog-files/3d-transforms/poster-circle.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96920

Patch Set 2 : Update based on Skia change #

Total comments: 2

Patch Set 3 : nit #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	skia/ext/vector_platform_device_skia.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

LGTM. Roll 2114 is in. 2116 should follow shortly. http://codereview.chromium.org/7620016/diff/3001/skia/ext/vector_platform_device_skia.cc File skia/ext/vector_platform_device_skia.cc (right): http://codereview.chromium.org/7620016/diff/3001/skia/ext/vector_platform_device_skia.cc#newcode190 skia/ext/vector_platform_device_skia.cc:190: ...

9 years, 4 months ago (2011-08-16 00:30:57 UTC) #2

vandebo (ex-Chrome)

http://codereview.chromium.org/7620016/diff/3001/skia/ext/vector_platform_device_skia.cc File skia/ext/vector_platform_device_skia.cc (right): http://codereview.chromium.org/7620016/diff/3001/skia/ext/vector_platform_device_skia.cc#newcode190 skia/ext/vector_platform_device_skia.cc:190: vector_device->pdf_device_->setOrigin(vector_device->getOrigin().fX, On 2011/08/16 00:30:57, Chris Guillory wrote: > Nit: ...

9 years, 4 months ago (2011-08-16 01:37:19 UTC) #3

Change committed as 96920