Issue 7620011: Mark the SkBitmap used for video uploads as volatile. This tells Ganesh (Skia) not to create and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7620011: Mark the SkBitmap used for video uploads as volatile. This tells Ganesh (Skia) not to create and... (Closed)

Created:
9 years, 4 months ago by Stephen White

Modified:
9 years, 4 months ago

Reviewers:
bsalomon, scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mark the SkBitmap used for video uploads as volatile. This tells Ganesh (Skia) not to create and destroy a GL texture on each upload of a new frame. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96551

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webkit/glue/media/video_renderer_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Stephen White

On 2011/08/11 15:42:58, bsalomon wrote: > On 2011/08/11 15:34:47, Stephen White wrote: > > LGTM ...

9 years, 4 months ago (2011-08-11 17:40:13 UTC) #3

why yes, you may!

LGTM

Expand Messages | Collapse Messages