Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_win.cc

Issue 7620005: Revert 96162 - Revert 96149 - Enable/disable input methods according to |text_input_type_| when a... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_win.cc
===================================================================
--- chrome/browser/renderer_host/render_widget_host_view_win.cc (revision 96328)
+++ chrome/browser/renderer_host/render_widget_host_view_win.cc (working copy)
@@ -209,6 +209,11 @@
return ::DefWindowProc(window, message, wparam, lparam);
}
+bool ShouldEnableIME(ui::TextInputType type) {
+ return type != ui::TEXT_INPUT_TYPE_NONE &&
+ type != ui::TEXT_INPUT_TYPE_PASSWORD;
+}
+
} // namespace
// RenderWidgetHostView --------------------------------------------------------
@@ -287,6 +292,10 @@
tab_switch_paint_time_ = TimeTicks::Now();
is_hidden_ = false;
EnsureTooltip();
+ if (ShouldEnableIME(text_input_type_))
+ ime_input_.EnableIME(m_hWnd);
+ else
+ ime_input_.DisableIME(m_hWnd);
render_widget_host_->WasRestored();
}
@@ -598,8 +607,7 @@
// as true. We need to support "can_compose_inline=false" for PPAPI plugins
// that may want to avoid drawing composition-text by themselves and pass
// the responsibility to the browser.
- bool is_enabled = (type != ui::TEXT_INPUT_TYPE_NONE &&
- type != ui::TEXT_INPUT_TYPE_PASSWORD);
+ bool is_enabled = ShouldEnableIME(type);
if (text_input_type_ != type) {
text_input_type_ = type;
if (is_enabled)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698