Issue 7619012: Breakpad: Ensure crash_service64.exe gets built on Buildbot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7619012: Breakpad: Ensure crash_service64.exe gets built on Buildbot (Closed)

Created:
9 years, 4 months ago by Mark Seaborn

Modified:
9 years, 4 months ago

Reviewers:
bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Breakpad: Ensure crash_service64.exe gets built on Buildbot Add crash_service64.exe in places where crash_service.exe is depended upon, otherwise it doesn't get built on Buildbot. Declaring run-time dependencies via Gyp dependencies is a hack: creating test_support_ui.a doesn't depend on crash_service.exe being present. But it seems to be the usual practice to sprinkle run-time dependencies in Gyp dependencies until the desired effect is achieved. BUG=89730 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96479

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages