chrome/browser/extensions/extension_special_storage_policy_unittest.cc - Issue 7619010: Session-only local storage cleared on exit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 7619010: Session-only local storage cleared on exit. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Code review comments (tiny). Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy.cc ('k') | chrome/browser/extensions/mock_extension_special_storage_policy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

index cbaf6edaf8c4f59688e3aacf73ee0937f8f3690b..bd7f2742026c04196d718d8e9cc41592ae951d40 100644

--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

@@ -118,7 +118,7 @@ TEST_F(ExtensionSpecialStoragePolicyTest, EmptyPolicy) {

const GURL kExtensionUrl("chrome-extension://bar");

scoped_refptr<ExtensionSpecialStoragePolicy> policy(

- new ExtensionSpecialStoragePolicy);

+ new ExtensionSpecialStoragePolicy(NULL));

ASSERT_FALSE(policy->IsStorageUnlimited(kHttpUrl));

ASSERT_FALSE(policy->IsStorageUnlimited(kHttpUrl)); // test cached result

@@ -133,7 +133,7 @@ TEST_F(ExtensionSpecialStoragePolicyTest, EmptyPolicy) {

TEST_F(ExtensionSpecialStoragePolicyTest, AppWithProtectedStorage) {

scoped_refptr<Extension> extension(CreateProtectedApp());

scoped_refptr<ExtensionSpecialStoragePolicy> policy(

- new ExtensionSpecialStoragePolicy);

+ new ExtensionSpecialStoragePolicy(NULL));

policy->GrantRightsForExtension(extension);

EXPECT_FALSE(policy->IsStorageUnlimited(extension->url()));

EXPECT_FALSE(policy->IsStorageUnlimited(GURL("http://explicit/")));

@@ -152,7 +152,7 @@ TEST_F(ExtensionSpecialStoragePolicyTest, AppWithProtectedStorage) {

TEST_F(ExtensionSpecialStoragePolicyTest, AppWithUnlimitedStorage) {

scoped_refptr<Extension> extension(CreateUnlimitedApp());

scoped_refptr<ExtensionSpecialStoragePolicy> policy(

- new ExtensionSpecialStoragePolicy);

+ new ExtensionSpecialStoragePolicy(NULL));

policy->GrantRightsForExtension(extension);

EXPECT_TRUE(policy->IsStorageProtected(GURL("http://explicit/")));

EXPECT_TRUE(policy->IsStorageProtected(GURL("http://explicit:6000/")));

@@ -181,7 +181,7 @@ TEST_F(ExtensionSpecialStoragePolicyTest, OverlappingApps) {

scoped_refptr<Extension> protected_app(CreateProtectedApp());

scoped_refptr<Extension> unlimited_app(CreateUnlimitedApp());

scoped_refptr<ExtensionSpecialStoragePolicy> policy(

- new ExtensionSpecialStoragePolicy);

+ new ExtensionSpecialStoragePolicy(NULL));

policy->GrantRightsForExtension(protected_app);

policy->GrantRightsForExtension(unlimited_app);