Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6472)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

Issue 7619009: [Mac] Fix the BookmarkMenuBridgeTest.TestAddItemToMenu after r96393. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm
index 6c2616a0e7c75246e0e84b7bd645b1c7e64ce1cf..a75629be72b24e6ad57e42571e7a6b471e552f15 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm
@@ -260,19 +260,19 @@ TEST_F(BookmarkMenuBridgeTest, TestAddItemToMenu) {
IDS_BOOMARK_BAR_OPEN_INCOGNITO, root, menu, true);
EXPECT_EQ(3, [menu numberOfItems]);
- title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL);
+ title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL);
item = [menu itemWithTitle:title];
EXPECT_TRUE(item);
EXPECT_EQ(@selector(openAllBookmarks:), [item action]);
EXPECT_TRUE([item isEnabled]);
- title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW);
+ title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW);
item = [menu itemWithTitle:title];
EXPECT_TRUE(item);
EXPECT_EQ(@selector(openAllBookmarksNewWindow:), [item action]);
EXPECT_TRUE([item isEnabled]);
- title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_INCOGNITO);
+ title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_INCOGNITO);
item = [menu itemWithTitle:title];
EXPECT_TRUE(item);
EXPECT_EQ(@selector(openAllBookmarksIncognitoWindow:), [item action]);
@@ -289,19 +289,19 @@ TEST_F(BookmarkMenuBridgeTest, TestAddItemToMenu) {
IDS_BOOMARK_BAR_OPEN_INCOGNITO, root, menu, false);
EXPECT_EQ(3, [menu numberOfItems]);
- title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL);
+ title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL);
item = [menu itemWithTitle:title];
EXPECT_TRUE(item);
EXPECT_EQ(nil, [item action]);
EXPECT_FALSE([item isEnabled]);
- title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW);
+ title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW);
item = [menu itemWithTitle:title];
EXPECT_TRUE(item);
EXPECT_EQ(nil, [item action]);
EXPECT_FALSE([item isEnabled]);
- title = l10n_util::GetNSString(IDS_BOOMARK_BAR_OPEN_INCOGNITO);
+ title = l10n_util::GetNSStringWithFixup(IDS_BOOMARK_BAR_OPEN_INCOGNITO);
item = [menu itemWithTitle:title];
EXPECT_TRUE(item);
EXPECT_EQ(nil, [item action]);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698