Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 7619008: Change kNotSignedInProfile to kInitialProfile to better reflect its usage. (Closed)

Created:
9 years, 4 months ago by Miranda Callahan
Modified:
9 years, 4 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Change kNotSignedInProfile to kInitialProfile to better reflect its usage. Change ProfileManager::GetCurrentProfile to ProfileManager::GetInitialProfile as well. BUG=none TEST=no change in profile behavior Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96540

Patch Set 1 #

Patch Set 2 : I can't spel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M chrome/browser/diagnostics/diagnostics_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/fast_shutdown_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Miranda Callahan
Either Elliot or Sailesh to review -- this is just renaming a method and variable ...
9 years, 4 months ago (2011-08-11 15:20:51 UTC) #1
sail
LGTM!
9 years, 4 months ago (2011-08-11 16:01:51 UTC) #2
sail
LGTM!
9 years, 4 months ago (2011-08-11 16:01:52 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 09:47:08 UTC) #4
Change committed as 96540

Powered by Google App Engine
This is Rietveld 408576698