chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm - Issue 7619007: [Mac] Call GetNSStringWithFixup() instead of just GetNSString() for bookmark menu items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

Issue 7619007: [Mac] Call GetNSStringWithFixup() instead of just GetNSString() for bookmark menu items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

index ea7b9a66af0684e8bfbb867cea2257eb9a60afab..3b1ddd1697d43d1c444c97e9ac8384054e1fe26c 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

@@ -275,7 +275,7 @@ void BookmarkMenuBridge::AddItemToMenu(int command_id,

const BookmarkNode* node,

NSMenu* menu,

bool enabled) {

- NSString* title = l10n_util::GetNSString(message_id);

+ NSString* title = l10n_util::GetNSStringWithFixup(message_id);

SEL action;

if (!enabled) {

// A nil action makes a menu item appear disabled. NSMenuItem setEnabled

« no previous file with comments | « no previous file | no next file » | no next file with comments »