Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 7619006: base: Remove using declaration of FundamentalValue as it's no longer necessary. (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, idana, ncarter (slow), rharrison, Raghu Simha, Erik does not do reviews, Paweł Hajdan Jr., achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, tim (not reviewing), yoshiki+watch_chromium.org, brettw-cc_chromium.org, estade+watch_chromium.org, tfarina, davemoore+watch_chromium.org
Visibility:
Public.

Description

base: Remove using declaration of FundamentalValue as it's no longer necessary. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -121 lines) Patch
M base/values.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extensions_quota_service_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/net/referrer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud_policy_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_provider_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_policy_cache_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/policy_map_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/user_policy_cache_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_notifier_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_adapter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/shown_sections_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/system_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 4 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 4 months ago (2011-08-11 14:23:43 UTC) #1
Evan Martin
9 years, 4 months ago (2011-08-11 15:19:23 UTC) #2
LGTM

On Thu, Aug 11, 2011 at 7:23 AM,  <tfarina@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> base: Remove using declaration of FundamentalValue as it's no longer
> necessary.
>
> BUG=None
> TEST=None
>
> R=evan@chromium.org
>
>
> Please review this at http://codereview.chromium.org/7619006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M base/values.h
>  M chrome/browser/chromeos/login/user_manager.cc
>  M chrome/browser/debugger/devtools_window.cc
>  M chrome/browser/extensions/extension_file_browser_private_api.cc
>  M chrome/browser/extensions/extensions_quota_service_unittest.cc
>  M chrome/browser/net/predictor.cc
>  M chrome/browser/net/predictor_api.cc
>  M chrome/browser/net/predictor_unittest.cc
>  M chrome/browser/net/referrer.cc
>  M chrome/browser/policy/cloud_policy_controller_unittest.cc
>  M chrome/browser/policy/cloud_policy_provider_unittest.cc
>  M chrome/browser/policy/configuration_policy_pref_store_unittest.cc
>  M chrome/browser/policy/device_policy_cache_unittest.cc
>  M chrome/browser/policy/policy_map_unittest.cc
>  M chrome/browser/policy/user_policy_cache_unittest.cc
>  M chrome/browser/prefs/pref_notifier_impl_unittest.cc
>  M chrome/browser/prefs/pref_value_store_unittest.cc
>  M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
>  M chrome/browser/sync/sync_ui_util.cc
>  M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
>  M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
>  M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
>  M chrome/browser/ui/webui/cookies_tree_model_adapter.cc
>  M chrome/browser/ui/webui/crashes_ui.cc
>  M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc
>  M chrome/browser/ui/webui/ntp/most_visited_handler.cc
>  M chrome/browser/ui/webui/ntp/shown_sections_handler.cc
>  M chrome/browser/ui/webui/options/advanced_options_handler.cc
>  M chrome/browser/ui/webui/options/browser_options_handler.cc
>  M chrome/browser/ui/webui/options/certificate_manager_handler.cc
>  M chrome/browser/ui/webui/options/chromeos/system_options_handler.cc
>  M chrome/browser/ui/webui/options/clear_browser_data_handler.cc
>  M chrome/browser/ui/webui/options/content_settings_handler.cc
>  M chrome/browser/ui/webui/options/font_settings_handler.cc
>  M chrome/browser/ui/webui/options/import_data_handler.cc
>  M chrome/browser/ui/webui/options/personal_options_handler.cc
>  M chrome/browser/ui/webui/plugins_ui.cc
>  M chrome/browser/ui/webui/print_preview_handler.cc
>  M chrome/browser/ui/webui/print_preview_ui.cc
>  M chrome/browser/ui/webui/task_manager_handler.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698