Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 7619005: Update Breakpad to r825 to pick up some clang warning-related fixes (Closed)

Created:
9 years, 4 months ago by Mark Mentovai
Modified:
9 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Update Breakpad to r825 to pick up some clang warning-related fixes: ------------------------------------------------------------------------ r825 | mark@chromium.org | 2011-08-11 09:47:38 -0400 (Thu, 11 Aug 2011) | 6 lines The process_id field is unsigned, so we need this cast in c++0x. Patch by Rafael Ávila de Espí­ndola <respindola@mozilla.com>; https://bugzilla.mozilla.org/show_bug.cgi?id=677644 ------------------------------------------------------------------------ r824 | mark@chromium.org | 2011-08-11 09:45:30 -0400 (Thu, 11 Aug 2011) | 8 lines The first field in a MDLocationDescriptor is a u_int32_t, so change this cast to the correct type. This fixes an error newer clang versions find in c++ 0x mode. Patch by Rafael Ávila de Espí­ndola <respindola@mozilla.com>; https://bugzilla.mozilla.org/show_bug.cgi?id=677641 ------------------------------------------------------------------------ r823 | mark@chromium.org | 2011-08-11 09:40:13 -0400 (Thu, 11 Aug 2011) | 2 lines Fix clang warnings. Review URL: http://breakpad.appspot.com/298002 ------------------------------------------------------------------------ r822 | mark@chromium.org | 2011-08-11 09:39:44 -0400 (Thu, 11 Aug 2011) | 3 lines Zero out the entire context on MD5_Final, not just the number of bytes in a pointer. Review URL: http://breakpad.appspot.com/298001 ------------------------------------------------------------------------ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
TBR (DEPS)
9 years, 4 months ago (2011-08-11 14:12:07 UTC) #1
Nico
9 years, 4 months ago (2011-08-11 14:44:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698