Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 7618052: make: always cd into target directory for rules/actions (Closed)

Created:
9 years, 4 months ago by Evan Martin
Modified:
9 years, 4 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make: always cd into target directory for rules/actions Rather than testing for a subdirectory, just always cd into the appropriate directory. Even when self.path is empty, we may have (via --generator-output) the output directory in an unexpected place. Sourceify() always expands to the proper place, even for '.'. Committed: http://code.google.com/p/gyp/source/detail?r=998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M pylib/gyp/generator/make.py View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
9 years, 4 months ago (2011-08-15 21:35:41 UTC) #1
Nico
9 years, 4 months ago (2011-08-15 21:50:02 UTC) #2
Can you add "Because Sourceify('') != '' if --generator-output is set" to the CL
description? A TEST= line might help future archeologists help understand the
motivation behind this change, too.

LGTM

Powered by Google App Engine
This is Rietveld 408576698