Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7618048: Move the core download files to content. (Closed)

Created:
9 years, 4 months ago by jam
Modified:
9 years, 4 months ago
Reviewers:
benjhayden
CC:
chromium-reviews, asanka, vrk (LEFT CHROMIUM), jam, acolwell+watch_chromium.org, mihaip+watch_chromium.org, dcheng, rginda+watch_chromium.org, ajwong+watch_chromium.org, Erik does not do reviews, tbarzic+watch_chromium.org, kkania, prasadt, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), jennb, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Randy Smith (Not in Mondays), jianli, annacc+watch_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, achuith+watch_chromium.org, Dmitry Titov, Aaron Boodman, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Move the core download files to content. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96829

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -4817 lines) Patch
M chrome/browser/app_controller_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +0 lines, -1 line 1 comment Download
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_remover.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/download/download_create_info.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/download/download_create_info.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/download/download_file.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/download/download_file.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/download/download_file_manager.h View 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/browser/download/download_file_manager.cc View 1 chunk +0 lines, -404 lines 0 comments Download
M chrome/browser/download/download_file_picker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_file_picker.cc View 1 chunk +0 lines, -1 line 1 comment Download
D chrome/browser/download/download_file_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M chrome/browser/download/download_history.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/download/download_item.h View 1 chunk +0 lines, -493 lines 0 comments Download
D chrome/browser/download/download_item.cc View 1 chunk +0 lines, -867 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/download/download_manager.h View 1 chunk +0 lines, -418 lines 0 comments Download
D chrome/browser/download/download_manager.cc View 1 chunk +0 lines, -1081 lines 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
D chrome/browser/download/download_request_handle.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/download/download_request_handle.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M chrome/browser/download/download_safe_browsing_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_shelf_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/download/download_state_info.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/download/download_state_info.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/download/download_status_updater.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/download/download_status_updater.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/download/download_status_updater_delegate.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/download/download_status_updater_unittest.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/browser/download/download_types.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/download/download_types.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/download/drag_download_file.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/download/drag_download_file.cc View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/download/mock_download_manager.h View 1 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_downloads_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_downloads_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/history/download_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/download_history_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_util_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/web_drag_source.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/custom_drag.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_in_progress_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_in_progress_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_context_menu_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/download/download_create_info.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/download/download_create_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/download/download_file.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/download/download_file.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/download/download_file_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/download/download_file_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + content/browser/download/download_file_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + content/browser/download/download_item.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/download/download_item.cc View 3 chunks +4 lines, -5 lines 1 comment Download
A + content/browser/download/download_manager.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/download/download_manager.cc View 2 chunks +5 lines, -6 lines 1 comment Download
A + content/browser/download/download_request_handle.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/download/download_request_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/download/download_state_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/download/download_state_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/download/download_status_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/download/download_status_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/download/download_status_updater_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/download/download_status_updater_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/download/download_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/download/download_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/download/mock_download_manager.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/save_package.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/x509_user_cert_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
TBR=rdsmith
9 years, 4 months ago (2011-08-15 19:56:28 UTC) #1
Randy Smith (Not in Mondays)
Ben: Can you take a look at this CL from the downloads perspective? It's TBR/landed ...
9 years, 4 months ago (2011-08-19 15:05:57 UTC) #2
benjhayden
Some IWYU nits but LGTM. http://codereview.chromium.org/7618048/diff/5018/chrome/browser/automation/automation_provider_observers.cc File chrome/browser/automation/automation_provider_observers.cc (left): http://codereview.chromium.org/7618048/diff/5018/chrome/browser/automation/automation_provider_observers.cc#oldcode28 chrome/browser/automation/automation_provider_observers.cc:28: #include "chrome/browser/download/download_item.h" Looks like ...
9 years, 4 months ago (2011-08-19 15:23:10 UTC) #3
jam
Regarding all the nits below, I didn't see a reason for both a .cc and ...
9 years, 4 months ago (2011-08-19 15:52:58 UTC) #4
benjhayden
9 years, 4 months ago (2011-08-19 16:16:14 UTC) #5 
Meh, don't worry about it. LGTM

On Fri, Aug 19, 2011 at 11:52 AM, John Abd-El-Malek <jam@chromium.org>wrote:

> Regarding all the nits below, I didn't see a reason for both a .cc and
> corresponding .h to include the same file. I left the include in the header,
> although I probably could have tried to see if I can forward declare only.
>
>
> On Fri, Aug 19, 2011 at 8:23 AM, <benjhayden@chromium.org> wrote:
>
>> Some IWYU nits but LGTM.
>>
>>
>> http://codereview.chromium.**org/7618048/diff/5018/chrome/**
>>
browser/automation/automation_**provider_observers.cc<http://codereview.chromium.org/7618048/diff/5018/chrome/browser/automation/automation_provider_observers.cc>
>> File chrome/browser/automation/**automation_provider_observers.**cc
>> (left):
>>
>> http://codereview.chromium.**org/7618048/diff/5018/chrome/**
>>
browser/automation/automation_**provider_observers.cc#**oldcode28<http://codereview.chromium.org/7618048/diff/5018/chrome/browser/automation/automation_provider_observers.cc#oldcode28>
>> chrome/browser/automation/**automation_provider_observers.**cc:28:
>> #include
>>
>> "chrome/browser/download/**download_item.h"
>> Looks like you forgot to add content/b/d/d_i.h, and this file uses
>> DownloadItem.
>>
>> http://codereview.chromium.**org/7618048/diff/5018/chrome/**
>>
browser/download/download_**file_picker.cc<http://codereview.chromium.org/7618048/diff/5018/chrome/browser/download/download_file_picker.cc>
>> File chrome/browser/download/**download_file_picker.cc (left):
>>
>> http://codereview.chromium.**org/7618048/diff/5018/chrome/**
>>
browser/download/download_**file_picker.cc#oldcode7<http://codereview.chromium.org/7618048/diff/5018/chrome/browser/download/download_file_picker.cc#oldcode7>
>> chrome/browser/download/**download_file_picker.cc:7: #include
>>
>> "chrome/browser/download/**download_manager.h"
>> Looks like you forgot to add content/b/d/d_m.h, and this file uses
>> DownloadManager.
>>
>> http://codereview.chromium.**org/7618048/diff/5018/content/**
>>
browser/download/download_**item.cc<http://codereview.chromium.org/7618048/diff/5018/content/browser/download/download_item.cc>
>> File content/browser/download/**download_item.cc (left):
>>
>> http://codereview.chromium.**org/7618048/diff/5018/content/**
>>
browser/download/download_**item.cc#oldcode25<http://codereview.chromium.org/7618048/diff/5018/content/browser/download/download_item.cc#oldcode25>
>> content/browser/download/**download_item.cc:25: #include
>>
>> "chrome/browser/download/**download_state_info.h"
>> Looks like you forgot to add content/b/d/d_s_i.h, and this file uses
>> DownloadStateInfo.
>>
>> http://codereview.chromium.**org/7618048/diff/5018/content/**
>>
browser/download/download_**manager.cc<http://codereview.chromium.org/7618048/diff/5018/content/browser/download/download_manager.cc>
>> File content/browser/download/**download_manager.cc (left):
>>
>> http://codereview.chromium.**org/7618048/diff/5018/content/**
>>
browser/download/download_**manager.cc#oldcode21<http://codereview.chromium.org/7618048/diff/5018/content/browser/download/download_manager.cc#oldcode21>
>> content/browser/download/**download_manager.cc:21: #include
>>
>> "chrome/browser/download/**download_request_handle.h"
>> Looks like you forgot to add content/b/d_r_h.h, and this file uses
>> DownloadRequestHandle.
>>
>>
>>
http://codereview.chromium.**org/7618048/<http://codereview.chromium.org/7618...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698