Issue 7618044: Fix a crash in the Extension Creator when crx is in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7618044: Fix a crash in the Extension Creator when crx is in use. (Closed)

Created:
9 years, 4 months ago by Finnur

Modified:
9 years, 4 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash in the Extension Creator when crx is in use. BUG=92537 TEST=Create a .crx file from within Chrome, open it up with 7-zip and edit one of the files within (to lock the crx file), then try recreating the crx file -- an error should appear (and no crash). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96937

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	chrome/app/generated_resources.grd	View		4 chunks	+20 lines, -0 lines	1 comment	Download
	M	chrome/browser/extensions/extension_creator.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

http://codereview.chromium.org/7618044/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7618044/diff/1/chrome/app/generated_resources.grd#newcode3975 chrome/app/generated_resources.grd:3975: Enable Ignore all further changes to this file. They ...

9 years, 4 months ago (2011-08-15 15:56:54 UTC) #1

lgtm (modulo ignored grd changes)

Expand Messages | Collapse Messages