Issue 7618043: [oobe] Adds icon support for the network drop-down button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7618043: [oobe] Adds icon support for the network drop-down button. (Closed)

Created:
9 years, 4 months ago by altimofeev

Modified:
9 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[oobe] Adds icon support for the network drop-down button. Note, network drop-down button was reimplemented using 'div' (was 'button') element. So keyboard processing logic was slightly changed - but the control should still behave as a standard 'select'. BUG=chromium-os:17335 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96924

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -22 lines)			Patch
	M	chrome/browser/resources/chromeos/login/oobe.css	View		2 chunks	+12 lines, -9 lines	0 comments	Download
	M	chrome/browser/resources/chromeos/login/oobe_screen_network.js	View		4 chunks	+38 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages