PPB_URLRequestInfo::AppendFileToBody using sync ipc

net/base/upload_data_stream.cc

Index: net/base/upload_data_stream.cc
diff --git a/net/base/upload_data_stream.cc b/net/base/upload_data_stream.cc
index 4a056f43557b6da1f316bbce3661cf47f4cedcb9..33cf1201a97780d9891e70b245fd33b86cd0a55b 100644
--- a/net/base/upload_data_stream.cc
+++ b/net/base/upload_data_stream.cc
@@ -6,6 +6,7 @@
 
 #include "base/file_util.h"
 #include "base/logging.h"
+#include "base/threading/thread_restrictions.h"
 #include "net/base/file_stream.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
@@ -108,6 +109,8 @@ int UploadDataStream::FillBuf() {
           static_cast<int>(std::min(next_element_remaining_,
                                     static_cast<uint64>(size_remaining)));
       if (count > 0) {
+        // Temporarily allow until fix: http://crbug.com/72001.
+        base::ThreadRestrictions::ScopedAllowIO allow_io;

[michaeln, 2011/08/15 18:12:11]

Was this just missing before or does something about this change actually not
conduct blocking IO on the IO thread where it didn't before?

[kinuko, 2011/08/16 04:00:53]

In my testing whenever I try uploading a file with or without this change the
browser (debug build) crashes here, so I assume this was missing before.

[darin (slow to review), 2011/08/16 17:28:36]

Yeah, I'd expect that this is needed.  I'm not sure why we didn't have it
before.

         if (next_element_stream_.get())
           rv = next_element_stream_->Read(buf_->data() + buf_len_, count, NULL);
         if (rv <= 0) {