Issue 7618037: base: Rename FileEnumerator::FILE_TYPE to FileEnumerator::FileType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7618037: base: Rename FileEnumerator::FILE_TYPE to FileEnumerator::FileType. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base: Rename FileEnumerator::FILE_TYPE to FileEnumerator::FileType. enum types should be named using CamelCase as class and function names, not using MACRO_STYLE. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96766

Patch Set 1 : #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -44 lines)			Patch
M	base/file_util.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	base/file_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_posix.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	base/file_util_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_unittest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	base/file_util_win.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	base/test/test_file_util_posix.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_file_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/zip.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/zip_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/duplicate_tree_detector.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/profiles/generate_profile.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/pepper_file_message_filter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/directory_lister.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/cache_util_posix.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/fileapi/file_system_file_util.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/fileapi/local_file_system_file_util.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/fileapi/obfuscated_file_system_file_util.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages